-
Notifications
You must be signed in to change notification settings - Fork 4
648: Combined Leaderboard and LeaderboardEmbed #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Available PR Commands
See: https://github.com/tahminator/codebloom/wiki/CI-Commands |
Title648: Combined Leaderboard and LeaderboardEmbed PR TypeEnhancement Description
Diagram Walkthroughflowchart LR
OrgEmbedView["OrgEmbedView (duplicate)"] -- removed --> CurrentLeaderboard["CurrentLeaderboard (shared)"]
LeaderboardEmbed["LeaderboardEmbed"] -- uses embedded mode --> CurrentLeaderboard
CurrentLeaderboard -- passes props --> LeaderboardIndex["LeaderboardIndex"]
URLParams["URL pageSize param"] -- parsed when embedded --> CurrentLeaderboard
OrgHeader["OrgHeader"] -- shown in embeds --> LeaderboardIndex
Filters["Filter controls"] -- hidden in embeds --> LeaderboardIndex
|
| Relevant files | |||||||
|---|---|---|---|---|---|---|---|
| Enhancement |
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
/deploy |
|
The command to deploy to staging for the commit 50c96f7 has been triggered. View action run |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
648
Description of changes
Checklist before review
Screenshots
Dev
Staging